szehon-ho commented on PR #8111: URL: https://github.com/apache/iceberg/pull/8111#issuecomment-1644395063
Thanks very much for the pr and the fix, can you add a test ? I have some test in https://github.com/apache/iceberg/blob/master/spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFiles.java to catch the removeDanglingDelete scenarios , I think it would fit here well. Thanks in advance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
