lintingbin2009 commented on code in PR #8111:
URL: https://github.com/apache/iceberg/pull/8111#discussion_r1271685956
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFiles.java:
##########
@@ -179,7 +179,7 @@ public void testIntPartition() throws Exception {
@Test
public void testDaysPartitionTransform() throws Exception {
- createTable("timestamp", "days(partition_col)");
+ createTable("timestamp", "days(`partition_col.type`)");
Review Comment:
I understand that changing the name of the partition from "partition_col" to
"partition_col.type" will not affect the current test coverage. If a test
passes with the partition name "partition_col.type", then it must also pass
with the partition name "partition_col".
And the modification you said is to add a test case such as
testParitionColWithDot to specifically test the case where the partition column
contains ".", without modifying the current test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
