szehon-ho commented on code in PR #8111:
URL: https://github.com/apache/iceberg/pull/8111#discussion_r1271260166
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFiles.java:
##########
@@ -179,7 +179,7 @@ public void testIntPartition() throws Exception {
@Test
public void testDaysPartitionTransform() throws Exception {
- createTable("timestamp", "days(partition_col)");
+ createTable("timestamp", "days(`partition_col.type`)");
Review Comment:
Hi, is it possible to leave this test, and just add a new test, in order to
keep existing coverage?
For example, we can add partitionCol as an argument to createTable (we can
rename existing partitionCol to be partitionTransform)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
