rdblue commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1274217235
##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -23,11 +23,16 @@
import java.util.Map;
import java.util.Set;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.apache.iceberg.view.ImmutableViewMetadata;
+import org.apache.iceberg.view.ViewVersion;
-/** Represents a change to table metadata. */
+/** Represents a change to table/view metadata. */
public interface MetadataUpdate extends Serializable {
void applyTo(TableMetadata.Builder metadataBuilder);
+ default void applyTo(ImmutableViewMetadata.Builder viewMetadataBuilder) {}
Review Comment:
I think this should throw `UnsupportedOperationException` and complain that
the update cannot be applied to a view. Otherwise, incorrect use would fail
silently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
