rdblue commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1274222095
##########
core/src/main/java/org/apache/iceberg/UpdateRequirement.java:
##########
@@ -135,6 +147,15 @@ public void validate(TableMetadata base) {
schemaId, base.currentSchemaId());
}
}
+
+ @Override
+ public void validate(ViewMetadata base) {
+ if (schemaId != base.currentSchemaId()) {
Review Comment:
This looks correct, but would we ever use it? You can't evolve the schema of
a view because the schema must match what the version produces. That means the
schema always changes with the view version (or is reused) and there isn't a
need to use this validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
