rdblue commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1274225735
##########
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##########
@@ -117,6 +141,11 @@ private void update(MetadataUpdate.AddSchema update) {
if (!addedSchema) {
if (base != null) {
require(new
UpdateRequirement.AssertLastAssignedFieldId(base.lastColumnId()));
+ } else if (viewMetadataBase != null) {
+ // TODO: is this correct here? we don't track lastColumnId in
ViewMetadata
Review Comment:
See the comment above. Short answer is that I don't think we actually need
_any_ assertions right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
