nastra commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1274945499
##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -60,6 +65,12 @@ public int formatVersion() {
public void applyTo(TableMetadata.Builder metadataBuilder) {
metadataBuilder.upgradeFormatVersion(formatVersion);
}
+
+ @Override
+ public void applyTo(ImmutableViewMetadata.Builder viewMetadataBuilder) {
+ viewMetadataBuilder.formatVersion(formatVersion);
+ viewMetadataBuilder.addChanges(new
MetadataUpdate.UpgradeFormatVersion(formatVersion));
Review Comment:
this is a bit difficult with a generated Builder unfortunately. One approach
to solve this would be to define our own `Builder` that could handle adding the
right metadata changes. See the implementation details of that Builder above
and let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
