nastra commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1274482678
##########
core/src/main/java/org/apache/iceberg/UpdateRequirement.java:
##########
@@ -114,6 +117,15 @@ public void validate(TableMetadata base) {
lastAssignedFieldId, base.lastColumnId());
}
}
+
+ @Override
+ public void validate(ViewMetadata base) {
+ if (base != null && base.schema().highestFieldId() !=
lastAssignedFieldId) {
Review Comment:
yes I agree this isn't correct, that's why I added a TODO to double-check
this during review. Thanks for clarifying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
