rdblue commented on code in PR #8096:
URL: https://github.com/apache/iceberg/pull/8096#discussion_r1276766481
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -556,6 +556,21 @@ public TableMetadata removeSnapshotsIf(Predicate<Snapshot>
removeIf) {
return new Builder(this).removeSnapshots(toRemove).build();
}
+ /**
+ * This will remove the snapshots matching the given predicate but will not
suppress those
+ * snapshots from the snapshot log. The snapshots that are being removed
must be lazily provided
+ * via the {@link TableMetadata#snapshotsSupplier}.
+ *
+ * @param removeIf The snapshots to be removed that will later be lazily
loaded via the configured
+ * {@link TableMetadata#snapshotsSupplier}
+ * @return a new TableMetadata with snapshots removed without suppressing
the removed snapshots
+ * from the snapshot log
+ */
+ public TableMetadata removeLazilyLoadedSnapshotsIf(Predicate<Snapshot>
removeIf) {
Review Comment:
I don't think that we want to introduce a new public method. The methods in
this section predate the builder, when we would tell the table metadata what
high-level changes to make. We don't want to add any more of these, but it's
also not worth removing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
