rdblue commented on code in PR #8096:
URL: https://github.com/apache/iceberg/pull/8096#discussion_r1277784679
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1646,7 +1674,7 @@ private static List<HistoryEntry> updateSnapshotLog(
List<HistoryEntry> newSnapshotLog = Lists.newArrayList();
for (HistoryEntry logEntry : snapshotLog) {
long snapshotId = logEntry.snapshotId();
- if (snapshotsById.containsKey(snapshotId)) {
+ if (snapshotsById.containsKey(snapshotId) ||
lazySnapshotLoadingEnabled) {
Review Comment:
> In my initial version of the code I had almost the same logic, but it was
a bit difficult to understand because we basically need to handle the snapshot
log handling both for the client and the server side.
I'm not following why this is a problem. On the server side there's no
`RemoveSnapshot` in changes, so the history is sent as-is. On the client side
the same would happen most of the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
