[GitHub] [iceberg] nastra commented on a diff in pull request #8096: Core: Don't supress snapshot history when lazy snapshot loading is enabled

Mon, 31 Jul 2023 08:06:24 -0700 


nastra commented on code in PR #8096:
URL: https://github.com/apache/iceberg/pull/8096#discussion_r1279445750


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1646,7 +1674,7 @@ private static List<HistoryEntry> updateSnapshotLog(
       List<HistoryEntry> newSnapshotLog = Lists.newArrayList();
       for (HistoryEntry logEntry : snapshotLog) {
         long snapshotId = logEntry.snapshotId();
-        if (snapshotsById.containsKey(snapshotId)) {
+        if (snapshotsById.containsKey(snapshotId) || 
lazySnapshotLoadingEnabled) {

Review Comment:
   In fact there are `RemoveSnapshot` entries on the server-side when 
`TableMetadata#removeSnapshotsIf(..)` is getting called, which can be seen 
below:
   
![image](https://github.com/apache/iceberg/assets/271029/c00d9670-14b2-4ee7-b790-cc025fdaef90)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to