ConeyLiu commented on code in PR #8243:
URL: https://github.com/apache/iceberg/pull/8243#discussion_r1286014596
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -334,5 +335,10 @@ private <T> boolean shouldRead(
return ROWS_MIGHT_MATCH;
}
}
+
+ @Override
+ public <T> Boolean handleNonReference(Bound<T> term) {
+ return ROWS_MIGHT_MATCH;
Review Comment:
I think here the `NonReference` should be `it is not a column reference
term`. It can be a transform term, for example `equal(year(ts), 10)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
