rdblue commented on code in PR #8243:
URL: https://github.com/apache/iceberg/pull/8243#discussion_r1286441070
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -334,5 +335,10 @@ private <T> boolean shouldRead(
return ROWS_MIGHT_MATCH;
}
}
+
+ @Override
+ public <T> Boolean handleNonReference(Bound<T> term) {
+ return ROWS_MIGHT_MATCH;
Review Comment:
@Fokko, I think at this point the columns are bound and transforms have
already been removed if they can be (e.g. if they can be translated to a normal
predicate on a partition field). This is the case where the transform is left
over because there is no corresponding partition field. We could implement
future optimizations to run the filter, but returning all rows is good enough
for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
