rdblue commented on code in PR #8243:
URL: https://github.com/apache/iceberg/pull/8243#discussion_r1286440177
##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java:
##########
@@ -938,6 +940,17 @@ public void testParquetTypePromotion() {
Assert.assertTrue("Should succeed with promoted schema", shouldRead);
}
+ @Test
+ public void testTransformFilter() {
+ Assumptions.assumeThat(format).isEqualTo(FileFormat.PARQUET);
+ boolean shouldRead =
+ new ParquetMetricsRowGroupFilter(SCHEMA, equal(truncate("required",
2), "some_value"), true)
+ .shouldRead(parquetSchema, rowGroupMetadata);
+ Assumptions.assumeThat(shouldRead)
Review Comment:
I think you want to use an assertion rather than an assumption? If you use
an assumption the test will be skipped if it fails, instead of failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
