Fokko commented on code in PR #7782:
URL: https://github.com/apache/iceberg/pull/7782#discussion_r1294981079
##########
python/pyiceberg/table/metadata.py:
##########
@@ -359,15 +387,6 @@ def check_sort_orders(cls, values: Dict[str, Any]) ->
Dict[str, Any]:
TableMetadata = Annotated[Union[TableMetadataV1, TableMetadataV2],
Field(discriminator="format_version")]
-class TableMetadataFactory(IcebergBaseModel):
Review Comment:
I've replaced this with a root-model so we don't have to do the
`f'{{"table_metadata": {data}}}'`. cc @aless10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
