Fokko commented on code in PR #7782:
URL: https://github.com/apache/iceberg/pull/7782#discussion_r1294993759
##########
python/pyiceberg/types.py:
##########
@@ -332,33 +382,46 @@ class ListType(IcebergType):
class Config:
fields = {"element_field": {"exclude": True}}
- type: Literal["list"] = "list"
+ type: Literal["list"] = Field(default="list")
element_id: int = Field(alias="element-id")
- element_type: IcebergType = Field(alias="element")
+ element_type: SerializeAsAny[IcebergType] = Field(alias="element")
element_required: bool = Field(alias="element-required", default=True)
- element_field: NestedField = Field(init=False, repr=False)
+ _element_field: NestedField = PrivateAttr()
+ _hash: int = PrivateAttr()
def __init__(
self, element_id: Optional[int] = None, element: Optional[IcebergType]
= None, element_required: bool = True, **data: Any
):
- data["element_id"] = data["element-id"] if "element-id" in data else
element_id
- data["element_type"] = element or data["element_type"]
- data["element_required"] = data["element-required"] if
"element-required" in data else element_required
- data["element_field"] = NestedField(
+ data["element-id"] = data["element-id"] if "element-id" in data else
element_id
+ data["element"] = element or data["element_type"]
+ data["element-required"] = data["element-required"] if
"element-required" in data else element_required
+ super().__init__(**data)
+ self._hash = hash(data.values())
+
+ @cached_property
+ def element_field(self) -> NestedField:
Review Comment:
I think this is much nicer than pre-creating a private attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
