wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1303600278
##########
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##########
@@ -170,7 +170,9 @@ private ManifestFile copyManifest(ManifestFile manifest) {
specsById,
newFile,
snapshotId(),
- summaryBuilder);
+ summaryBuilder,
+ current.properties().get(TableProperties.AVRO_COMPRESSION),
Review Comment:
Funnily enough, this is what @sumeetgajjar did initially (see
https://github.com/apache/iceberg/pull/6799/commits/62cd446ffc99d83062e2082acb5a26cdfa517c00).
However, he changed it after the initial feedback (see
https://github.com/apache/iceberg/pull/6799/commits/7ab1d5c26bddca0e3540b12eeae48a5be3c2cd84).
The feedback that led him to do this is from @rdblue:
https://github.com/apache/iceberg/pull/5893#issuecomment-1267261389 (see also
https://github.com/apache/iceberg/pull/5893#discussion_r987094412).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
