wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1332298345
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -52,20 +52,38 @@ public abstract class ManifestWriter<F extends
ContentFile<F>> implements FileAp
private long deletedRows = 0L;
private Long minDataSequenceNumber = null;
- private ManifestWriter(PartitionSpec spec, OutputFile file, Long snapshotId)
{
+ private ManifestWriter(
+ PartitionSpec spec,
+ OutputFile file,
+ Long snapshotId,
+ String compressionCodec,
+ Integer compressionLevel) {
this.file = file;
this.specId = spec.specId();
- this.writer = newAppender(spec, file);
+ this.writer = newAppender(spec, file, compressionCodec, compressionLevel);
this.snapshotId = snapshotId;
this.reused = new GenericManifestEntry<>(spec.partitionType());
this.stats = new PartitionSummary(spec);
}
protected abstract ManifestEntry<F> prepare(ManifestEntry<F> entry);
+ /**
+ * @deprecated since 1.4.0, will be removed in 1.5.0; use {@link
+ * ManifestWriter#newAppender(PartitionSpec, OutputFile, String,
Integer)} instead.
+ */
+ @Deprecated
protected abstract FileAppender<ManifestEntry<F>> newAppender(
PartitionSpec spec, OutputFile outputFile);
+ protected FileAppender<ManifestEntry<F>> newAppender(
Review Comment:
I'm not sure I understand your comment. I'm keeping the existing method
abstract so as not to break the API. This one has an implementation, so it
cannot be abstract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
