wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1332358837
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -236,12 +254,22 @@ ManifestFile writeManifest(DataFile... files) throws
IOException {
}
ManifestFile writeManifest(Long snapshotId, DataFile... files) throws
IOException {
- File manifestFile = temp.newFile("input.m0.avro");
+ return writeManifest(snapshotId, null, files);
+ }
+
+ ManifestFile writeManifest(Long snapshotId, String compressionCodec,
DataFile... files)
+ throws IOException {
+ File manifestFile = temp.newFile();
Review Comment:
Firstly, `TestManifestListVersions` is about testing versions (v1 versus
v2). Secondly, `TestManifestListVersions` has a `writeManifestList` method
(which uses an `InMemoryOutputFile` as you observed), but it doesn't have any
`writeManifest` method. So there is nothing in `TestManifestListVersions` to
reuse for this, and the tests I'm adding around compression in manifests and
manifest lists do not fit the purpose of `TestManifestListVersions`.
I don't think it's an issue that we're actually writing to disk, is it?
There are other test classes calling `writeManifest` (not just
`TestManifestWriter` and `TestManifestListWriter`) and I didn't check if and
how they might be affected if we change this to using `InMemoryOutputFile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
