amogh-jahagirdar commented on code in PR #8397:
URL: https://github.com/apache/iceberg/pull/8397#discussion_r1306312314
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -436,6 +439,12 @@ public void commit() {
}
}
+ private void cleanupIfPossible(RuntimeException exception) {
+ if (!strictCleanup || exception instanceof CleanableFailure) {
+ Exceptions.suppressAndThrow(exception, this::cleanAll);
+ }
+ }
Review Comment:
I did a separate helper to avoid checkstyle complaining about cyclomatic
complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
