amogh-jahagirdar commented on code in PR #8397:
URL: https://github.com/apache/iceberg/pull/8397#discussion_r1314031511
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -319,15 +320,7 @@ private void commitCreateTransaction() {
} catch (RuntimeException e) {
// the commit failed and no files were committed. clean up each update.
- Tasks.foreach(updates)
- .suppressFailureWhenFinished()
- .run(
- update -> {
- if (update instanceof SnapshotProducer) {
- ((SnapshotProducer) update).cleanAll();
- }
- });
-
+ computeUncommittedFiles();
Review Comment:
Right, it's possible that during the create/replace we get a 500 but the
create/replace actually was successful. So we still need the cleanable failure
check. I realized I'm also missing tests for create/replace/simple transactions
so I'll add those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
