amogh-jahagirdar commented on code in PR #8397:
URL: https://github.com/apache/iceberg/pull/8397#discussion_r1316210793
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -319,15 +320,7 @@ private void commitCreateTransaction() {
} catch (RuntimeException e) {
// the commit failed and no files were committed. clean up each update.
- Tasks.foreach(updates)
- .suppressFailureWhenFinished()
- .run(
- update -> {
- if (update instanceof SnapshotProducer) {
- ((SnapshotProducer) update).cleanAll();
- }
- });
-
+ computeUncommittedFiles();
Review Comment:
I've updated. If I'm not missing anything we would still want to preserve
the behavior of cleaning up the files in the `finally` block because that set
of deleted files would the files from previous commit attempts (this was
already happening regardless of commit outcome, including
CommitUnknownException). We should be able to clean those files up in any
situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
