nastra commented on code in PR #8945:
URL: https://github.com/apache/iceberg/pull/8945#discussion_r1376215669
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2Base.java:
##########
@@ -231,20 +231,20 @@ protected void testChangeLogOnIdKey(String branch) throws
Exception {
ImmutableList.of(record(1, "ddd"), record(2, "ddd")));
if (partitioned &&
writeDistributionMode.equals(TableProperties.WRITE_DISTRIBUTION_MODE_HASH)) {
- AssertHelpers.assertThrows(
- "Should be error because equality field columns don't include all
partition keys",
- IllegalStateException.class,
- "should be included in equality fields",
- () -> {
- testChangeLogs(
- ImmutableList.of("id"),
- row -> row.getField(ROW_ID_POS),
- false,
- elementsPerCheckpoint,
- expectedRecords,
- branch);
- return null;
- });
+ Assertions.assertThatThrownBy(
+ () -> {
Review Comment:
the {} are not needed and can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
