nastra commented on code in PR #8945:
URL: https://github.com/apache/iceberg/pull/8945#discussion_r1376219994
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##########
@@ -337,12 +337,10 @@ public void testIncrementalFromSnapshotIdWithEmptyTable()
throws Exception {
ContinuousSplitPlannerImpl splitPlanner =
new ContinuousSplitPlannerImpl(
tableResource.tableLoader().clone(),
scanContextWithInvalidSnapshotId, null);
-
- AssertHelpers.assertThrows(
- "Should detect invalid starting snapshot id",
- IllegalArgumentException.class,
- "Start snapshot id not found in history: 1",
- () -> splitPlanner.planSplits(null));
+ Assertions.assertThatThrownBy(() -> splitPlanner.planSplits(null))
+ .as("Should detect invalid starting snapshot id")
Review Comment:
unresolving this as it hasn't been addressed
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##########
@@ -365,12 +363,10 @@ public void testIncrementalFromSnapshotIdWithInvalidIds()
throws Exception {
ContinuousSplitPlannerImpl splitPlanner =
new ContinuousSplitPlannerImpl(
tableResource.tableLoader().clone(),
scanContextWithInvalidSnapshotId, null);
-
- AssertHelpers.assertThrows(
- "Should detect invalid starting snapshot id",
- IllegalArgumentException.class,
- "Start snapshot id not found in history: " + invalidSnapshotId,
- () -> splitPlanner.planSplits(null));
+ Assertions.assertThatThrownBy(() -> splitPlanner.planSplits(null))
+ .as("Should detect invalid starting snapshot id")
Review Comment:
can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
