nastra commented on code in PR #8945:
URL: https://github.com/apache/iceberg/pull/8945#discussion_r1376219315
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java:
##########
@@ -254,30 +254,24 @@ public void testInvalidMaxPlanningSnapshotCount() {
.monitorInterval(Duration.ofMillis(100))
.maxPlanningSnapshotCount(0)
.build();
-
- AssertHelpers.assertThrows(
- "Should throw exception because of invalid config",
- IllegalArgumentException.class,
- "must be greater than zero",
- () -> {
- createFunction(scanContext1);
- return null;
- });
+ Assertions.assertThatThrownBy(
+ () -> {
Review Comment:
same as above
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java:
##########
@@ -254,30 +254,24 @@ public void testInvalidMaxPlanningSnapshotCount() {
.monitorInterval(Duration.ofMillis(100))
.maxPlanningSnapshotCount(0)
.build();
-
- AssertHelpers.assertThrows(
- "Should throw exception because of invalid config",
- IllegalArgumentException.class,
- "must be greater than zero",
- () -> {
- createFunction(scanContext1);
- return null;
- });
+ Assertions.assertThatThrownBy(
+ () -> {
+ createFunction(scanContext1);
+ })
+ .isInstanceOf(IllegalArgumentException.class)
+ .hasMessage("The max-planning-snapshot-count must be greater than
zero");
ScanContext scanContext2 =
ScanContext.builder()
.monitorInterval(Duration.ofMillis(100))
.maxPlanningSnapshotCount(-10)
.build();
-
- AssertHelpers.assertThrows(
- "Should throw exception because of invalid config",
- IllegalArgumentException.class,
- "must be greater than zero",
- () -> {
- createFunction(scanContext2);
- return null;
- });
+ Assertions.assertThatThrownBy(
+ () -> {
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
