rdblue commented on a change in pull request #922: URL: https://github.com/apache/iceberg/pull/922#discussion_r435432470
########## File path: api/src/main/java/org/apache/iceberg/UpdatePartitionSpec.java ########## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import org.apache.iceberg.exceptions.CommitFailedException; +import org.apache.iceberg.transforms.Transform; + +/** + * API for partition spec evolution. + * <p> + * When committing, these changes will be applied to the current table metadata. Commit conflicts + * will not be resolved and will result in a {@link CommitFailedException}. + */ +public interface UpdatePartitionSpec extends PendingUpdate<PartitionSpec> { + + /** + * Clear all partition fields in the current partition spec. + * <p> + * This will create a new partition spec without any partition field. + * Partition field IDs is automatically assigned and will be updated during the commit. + * Table schema should be obtained from the current table metadata + * + * @return this for method chaining + */ + UpdatePartitionSpec clear(); + + /** + * Add a new partition field with identity transform to the partition spec. + * <p> + * The partition field id is automatically assigned and will be updated during the commit. + * + * @param sourceName the field name of the source field in the {@link PartitionSpec spec's} table schema + * @param targetName the name of this partition field + * @return this for method chaining + */ + UpdatePartitionSpec addIdentityField(String sourceName, String targetName); + + /** + * Add a new partition field with identity transform to the partition spec. + * <p> + * The partition field name is automatically assigned set. Review comment: I think it's okay to leave this out. I think it is clear enough that an unspecified name is given a default value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
