rdblue commented on a change in pull request #922: URL: https://github.com/apache/iceberg/pull/922#discussion_r441186392
########## File path: core/src/test/java/org/apache/iceberg/TestPartitionSpecUpdate.java ########## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import org.junit.Assert; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +@RunWith(Parameterized.class) +public class TestPartitionSpecUpdate extends TableTestBase { + + private int[] expectedFieldIds; + + private String[] expectedSpecs; + + @Parameterized.Parameters + public static Object[][] parameters() { + return new Object[][] { + new Object[] { 1, new int[]{ 1000, 1001, 1001, 1000, 1000 }, Review comment: I would prefer not to put expected IDs in parameters. This makes it difficult to read and understand the test cases. I find myself going back and forth and counting indexes to validate that the cases look correct. Instead, when cases differ I'd like to use `V1Assert.assertEquals` and `V2Assert.assertEquals`, which are only enforced if the format version is v1 or v2. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
