rdblue commented on a change in pull request #1115:
URL: https://github.com/apache/iceberg/pull/1115#discussion_r441029110
##########
File path: core/src/main/java/org/apache/iceberg/AllEntriesTable.java
##########
@@ -81,23 +79,14 @@ public Schema schema() {
super(ops, table, schema);
}
- private Scan(
- TableOperations ops, Table table, Long snapshotId, Schema schema,
Expression rowFilter,
- boolean ignoreResiduals, boolean caseSensitive, boolean colStats,
- Collection<String> selectedColumns, ImmutableMap<String, String>
options) {
- super(
- ops, table, snapshotId, schema, rowFilter, ignoreResiduals,
- caseSensitive, colStats, selectedColumns, options);
+ private Scan(TableOperations ops, Table table, Schema schema,
TableScanContext context) {
+ super(ops, table, schema, context);
}
@Override
- protected TableScan newRefinedScan(
- TableOperations ops, Table table, Long snapshotId, Schema schema,
Expression rowFilter,
- boolean ignoreResiduals, boolean caseSensitive, boolean colStats,
Collection<String> selectedColumns,
- ImmutableMap<String, String> options) {
- return new Scan(
- ops, table, snapshotId, schema, rowFilter, ignoreResiduals,
- caseSensitive, colStats, selectedColumns, options);
+ protected TableScan newRefinedScan(TableOperations ops, Table table,
Schema schema,
+ TableScanContext context) {
+ return new Scan(ops, table, schema, context.copy());
Review comment:
If the context is immutable, we don't need to call `copy`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
