rdblue commented on a change in pull request #1115:
URL: https://github.com/apache/iceberg/pull/1115#discussion_r441034330
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -243,6 +224,7 @@ public TableScan ignoreResiduals() {
@Override
public CloseableIterable<CombinedScanTask> planTasks() {
+ ImmutableMap<String, String> options = context.options();
Review comment:
We avoid leaking specific classes through the API. Can you update this
to use `Map` instead? The getter method `options` should also only return `Map`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
