nastra commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1668371941
##########
data/src/test/java/org/apache/iceberg/RecordWrapperTest.java:
##########
@@ -103,11 +103,12 @@ public void testNestedSchema() {
}
private void generateAndValidate(Schema schema) {
- generateAndValidate(schema, Assert::assertEquals);
+ generateAndValidate(
+ schema, (actual, message, expected) ->
assertThat(actual).as(message).isEqualTo(expected));
}
public interface AssertMethod {
- void assertEquals(String message, StructLikeWrapper expected,
StructLikeWrapper actual);
+ void assertEquals(StructLikeWrapper actual, String message,
StructLikeWrapper expected);
Review Comment:
it would be better to just keep this signature for now as otherwise it's
causing lots of unrelated changes across Spark/Flink. That being said, focusing
on the `data` module is the right thing here and seems to be the scope of your
PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
