nastra commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1668374723
##########
data/src/test/java/org/apache/iceberg/TestMergingMetrics.java:
##########
@@ -110,22 +110,17 @@ public abstract class TestMergingMetrics<T> {
MAP_FIELD_2,
STRUCT_FIELD);
- protected final FileFormat fileFormat;
-
- @Parameterized.Parameters(name = "fileFormat = {0}")
- public static Object[] parameters() {
- return new Object[] {FileFormat.PARQUET, FileFormat.ORC};
- }
+ protected abstract FileAppender<T> writeAndGetAppender(List<Record> records)
throws Exception;
- public TestMergingMetrics(FileFormat fileFormat) {
- this.fileFormat = fileFormat;
+ @Parameters(name = "fileFormat = {0}")
+ public static Collection<FileFormat> parameters() {
Review Comment:
I don't think there's a particular reason to change the signature of this
method. Just updating it to the correct `@Parameters` should be enough here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
