nastra commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1668383200
##########
data/src/test/java/org/apache/iceberg/io/TestWriterMetrics.java:
##########
@@ -98,9 +100,9 @@ public TestWriterMetrics(FileFormat fileFormat) {
protected abstract T toGenericRow(int value, int repeated);
- @Before
+ @BeforeEach
public void setupTable() throws Exception {
- File tableDir = temp.newFolder();
+ File tableDir = new File(tempDir, "table");
Review Comment:
this should use `Files.createTempDirectory(temp, "junit").toFile()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]