nastra commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1668408135
##########
data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java:
##########
@@ -45,34 +44,19 @@ public class GenericAppenderHelper {
private final Table table;
private final FileFormat fileFormat;
- private final TemporaryFolder tmp;
- private final Path temp;
+ private final Path tempDir;
private final Configuration conf;
- @Deprecated
public GenericAppenderHelper(
- Table table, FileFormat fileFormat, TemporaryFolder tmp, Configuration
conf) {
+ Table table, FileFormat fileFormat, Path tempDir, Configuration conf) {
Review Comment:
I don't think you can make changes in this file at this point, because there
are still places across the codebase that use this and pass a
`TemporaryFolder`. That being said, please revert the changes to this file. We
can only remove this constructor once all the other places (most likely Flink)
are converted to JUnit5 (which isn't the scope of this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
