nastra commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1668393174
##########
data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java:
##########
@@ -85,14 +84,14 @@ private static void assertEquals(Type type, Object
expected, Object actual) {
case UUID:
case BINARY:
case DECIMAL:
- Assert.assertEquals(
- "Primitive value should be equal to expected for type " + type,
expected, actual);
+ assertThat(actual)
+ .as("Primitive value should be equal to expected for type " + type)
+ .isEqualTo(expected);
break;
case FIXED:
assertThat(expected).as("Expected should be a
byte[]").isInstanceOf(byte[].class);
assertThat(expected).as("Actual should be a
byte[]").isInstanceOf(byte[].class);
- Assert.assertArrayEquals(
- "Array contents should be equal", (byte[]) expected, (byte[])
actual);
+ assertThat((byte[]) actual).as("Array contents should be
equal").isEqualTo(expected);
Review Comment:
is the casting still necessary here? I believe this should also work without
having to cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
