nastra commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1668393839
##########
data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java:
##########
@@ -45,34 +44,19 @@ public class GenericAppenderHelper {
private final Table table;
private final FileFormat fileFormat;
- private final TemporaryFolder tmp;
- private final Path temp;
+ private final Path tempDir;
Review Comment:
Is there a particular reason to name this `tempDir` everywhere in the PR
rather than just keeping it `temp`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
