attilakreiner commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1670424465
##########
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java:
##########
@@ -195,10 +192,9 @@ private void appendData() throws IOException {
sharedTable.newFastAppend().appendFile(file13).appendFile(file23).appendFile(file33).commit();
}
- @Before
+ @BeforeEach
public void createTables() throws IOException {
- File location = temp.newFolder("shared");
- Assert.assertTrue(location.delete());
+ File location = new File(tempDir, "shared");
Review Comment:
done (it's fixed in all this PR now)
##########
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java:
##########
@@ -225,12 +221,11 @@ public void createTables() throws IOException {
sharedTable.newAppend().appendFile(file1).appendFile(file2).appendFile(file3).commit();
}
- @Test
+ @TestTemplate
public void testRandomData() throws IOException {
List<Record> expected = RandomGenericData.generate(SCHEMA, 1000,
435691832918L);
- File location = temp.newFolder(format.name());
- Assert.assertTrue(location.delete());
+ File location = new File(tempDir, format.name());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
