attilakreiner commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1670429681
##########
data/src/test/java/org/apache/iceberg/io/TestWriterMetrics.java:
##########
@@ -128,25 +130,25 @@ public void verifySortedColMetric() throws Exception {
// Only two sorted fields (id, structField.longValue) will have metrics
Map<Integer, ByteBuffer> lowerBounds = dataFile.lowerBounds();
- Assert.assertEquals(
- 3, (int) Conversions.fromByteBuffer(Types.IntegerType.get(),
lowerBounds.get(1)));
- Assert.assertFalse(lowerBounds.containsKey(2));
- Assert.assertFalse(lowerBounds.containsKey(3));
- Assert.assertFalse(lowerBounds.containsKey(4));
- Assert.assertEquals(
- 3L, (long) Conversions.fromByteBuffer(Types.LongType.get(),
lowerBounds.get(5)));
+ assertThat((int) Conversions.fromByteBuffer(Types.IntegerType.get(),
lowerBounds.get(1)))
+ .isEqualTo(3);
+ assertThat(lowerBounds).doesNotContainKey(2);
Review Comment:
Cool, but keeping them on separate lines makes it actually more readable
IMHO. Pls LMK if I should change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
