attilakreiner commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1670431187
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestRowDataWrapper.java:
##########
@@ -83,8 +83,8 @@ protected void generateAndValidate(Schema schema,
RecordWrapperTest.AssertMethod
assertMethod.assertEquals(
"Should have expected StructLike values",
- actualWrapper.set(recordStructLike),
- expectedWrapper.set(rowDataStructLike));
+ expectedWrapper.set(rowDataStructLike),
Review Comment:
Yep, checked it. The signature is `void assertEquals(String message,
StructLikeWrapper expected, StructLikeWrapper actual)`
https://github.com/apache/iceberg/blob/dbee20cb80806e2e4e19056b42ebf697ca0df552/data/src/test/java/org/apache/iceberg/RecordWrapperTest.java#L111
So the correct order is `message`, `expected`, `actual` like this. Pls LMK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
