HeartSaVioR commented on a change in pull request #1285:
URL: https://github.com/apache/iceberg/pull/1285#discussion_r464909482
##########
File path: core/src/main/java/org/apache/iceberg/BaseCombinedScanTask.java
##########
@@ -26,19 +26,19 @@
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
public class BaseCombinedScanTask implements CombinedScanTask {
- private final List<FileScanTask> tasks;
+ private final FileScanTask[] tasks;
public BaseCombinedScanTask(FileScanTask... tasks) {
- this.tasks = ImmutableList.copyOf(tasks);
+ this.tasks = tasks;
}
public BaseCombinedScanTask(List<FileScanTask> tasks) {
- this.tasks = ImmutableList.copyOf(tasks);
+ this.tasks = tasks.stream().toArray(FileScanTask[]::new);
Review comment:
I guess the new code will also throw NPE in any way, but with different
error message which is probably less helpful. Checking the null with
Precondition sounds good to me, and I prefer defensive programming unless it's
on critical path. :) Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
