HeartSaVioR commented on a change in pull request #1285:
URL: https://github.com/apache/iceberg/pull/1285#discussion_r465334038
##########
File path:
spark/src/test/java/org/apache/iceberg/actions/TestRewriteDataFilesAction.java
##########
@@ -311,6 +325,128 @@ public void testRewriteLargeTableHasResiduals() {
Assert.assertEquals("Rows must match", records, actualRecords);
}
+ @Test
+ public void testBaseCombinedScanTaskKryoSerialization() throws Exception {
Review comment:
I think I missed to migrate comments from the origin PR, my bad.
> I decided to add the serde tests of BaseCombinedScanTask here, because it
seems to require non-trivial efforts to create BasedCombinedScanTask by hand. I
can move out if we'd like to have separate suite with manually crafted test
objects.
So that was the plan to reduce lots of manual lines by hand, but now I
realized the new test cases would just duplicate small code in
TestRewriteDataFilesAction even it becomes a new test suite. I'll add a new
test suite. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
