rdblue commented on a change in pull request #1285:
URL: https://github.com/apache/iceberg/pull/1285#discussion_r465201829
##########
File path:
spark/src/test/java/org/apache/iceberg/actions/TestRewriteDataFilesAction.java
##########
@@ -311,6 +325,128 @@ public void testRewriteLargeTableHasResiduals() {
Assert.assertEquals("Rows must match", records, actualRecords);
}
+ @Test
+ public void testBaseCombinedScanTaskKryoSerialization() throws Exception {
Review comment:
Why add these tests to `TestRewriteDataFilesAction`? These aren't
specific to that action and the code change is in core. I think it would be
more better to add these tests to `TestDataFileSerialization`, since that is
quite similar. That, or create a new test suite, `TestScanTaskSerialization`.
Either one is fine with me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
