rdblue commented on a change in pull request #1350:
URL: https://github.com/apache/iceberg/pull/1350#discussion_r474291711
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java
##########
@@ -267,7 +267,7 @@ private static TypeDescription buildOrcProjection(Integer
fieldId, Type type, bo
// e.g. renaming column c -> d and adding new column d
String name = Optional.ofNullable(mapping.get(nestedField.fieldId()))
.map(OrcField::name)
- .orElse(nestedField.name() + "_r" + nestedField.fieldId());
+ .orElseGet(() -> nestedField.name() + "_r" +
nestedField.fieldId());
Review comment:
Nice that it catches these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
