RussellSpitzer commented on a change in pull request #1350:
URL: https://github.com/apache/iceberg/pull/1350#discussion_r474293815
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -347,7 +347,9 @@ public String toString() {
}
@Override
- public void setBatchSize(int batchSize) {}
+ public void setBatchSize(int batchSize) {
+
Review comment:
Yep, we actually did for the Private Constructors as well but we were
ignoring that *everywhere* so I deleted that check
```
<module name="RightCurly"> <!-- Java Style Guide: Nonempty blocks: K
& R style -->
<property name="option" value="alone"/>
<property name="tokens" value="CLASS_DEF, **METHOD_DEF**,
CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT"/>
</module>
```
Basically Check-style was just broken before (see my comment on this PR) and
didn't work correctly on empty blocks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
