rdblue commented on a change in pull request #1350:
URL: https://github.com/apache/iceberg/pull/1350#discussion_r474828081
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -347,7 +347,9 @@ public String toString() {
}
@Override
- public void setBatchSize(int batchSize) {}
+ public void setBatchSize(int batchSize) {
+
Review comment:
I think that's what we do in most places isn't it? I was hoping that
with this update it wouldn't be too many places to change. Probably good to
update them to all be standard, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]