pvary commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479191540
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -465,9 +495,14 @@ protected void finalize() throws Throwable {
super.finalize();
if (!closed) {
close(); // releasing resources is more important than printing the
warning
- String trace = Joiner.on("\n\t").join(
+ String trace = Joiner.on("\\n\t").join(
Review comment:
When I have to read Hive logs where there are plenty of concurrent
queries running parallel, extra log lines will appear inside if we have
multiline logs which will make them hard to read (even harder than the one
proposed above).
Also only the first line of the log will get the timestamp and other log
header information, which will make it hard to use any log analyzer tool to
check them.
These are the main reasons in Hive we usually try to avoid multiline logs,
and accept the drawback of the "hardness" of reading them.
I am open to suggestions, even reverting back to this change if you strongly
feel that it should remain as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
