pvary commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479268647
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -143,9 +144,11 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
// TODO add lock heart beating for cases where default lock timeout is
too low.
Table tbl;
if (base != null) {
+ LOG.info("Committing existing table [{}]", fullName);
Review comment:
This was a bit more involved. Please check the resulting method changes:
- BaseMetastoreTableOperations did not know about the tableName - added
fullName
- BaseMetastoreTableOperations#commit did not know about the
newMetadataLocation - added newMetadataLocation as a return value for doCommit
- Added Stopwatch to the used guava classes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
