pvary commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479494971
##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -63,7 +66,10 @@ private TableIdentifier
canonicalizeIdentifier(TableIdentifier tableIdentifier)
@Override
public Table loadTable(TableIdentifier ident) {
- return tableCache.get(canonicalizeIdentifier(ident), catalog::loadTable);
+ Table result = tableCache.get(canonicalizeIdentifier(ident),
catalog::loadTable);
+ LOG.info("Table loaded by catalog: {}", result);
Review comment:
I was thinking around the same lines, but I did not find a way to
differentiate between the cache hit, and the cache miss.
Shall we just remove the log, or you have some idea how to check for cache
hit?
Removed the log for the time being.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
