rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479423556
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -285,7 +300,15 @@ public boolean setProperties(Namespace namespace,
Map<String, String> propertie
parameter.putAll(properties);
Database database = convertToDatabase(namespace, parameter);
- return alterHiveDataBase(namespace, database);
+ boolean result = alterHiveDataBase(namespace, database);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Set properties for: {} to: {} resulted: {}",
+ namespace,
+ Joiner.on(",").withKeyValueSeparator("=").join(properties),
+ result);
Review comment:
I'm really skeptical that this is a good idea. Properties can contain
sensitive information that we don't want to leak into logs. If the operation
succeeds, we can get the properties directly from the table. If it fails, we
will get an exception and the properties that were attempted aren't very
important (the user should also be able to tell us what they were).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
