pvary commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479498443
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -296,7 +319,10 @@ public boolean removeProperties(Namespace namespace,
Set<String> properties) {
properties.forEach(key -> parameter.put(key, null));
Database database = convertToDatabase(namespace, parameter);
- return alterHiveDataBase(namespace, database);
+ boolean result = alterHiveDataBase(namespace, database);
+ LOG.debug("Remove properties: {} from: {} resulted: {}", properties,
namespace, result);
Review comment:
We do not log the actual values, just the properties we are removing.
Could it also contain sensitive information?
If not I would keep the log message, so we can be able to trace things in
case of trouble
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
