wgtmac commented on code in PR #34:
URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923919166
##########
cmake_modules/IcebergThirdpartyToolchain.cmake:
##########
@@ -126,3 +126,68 @@ endfunction()
if(ICEBERG_ARROW)
resolve_arrow_dependency()
endif()
+
+# ----------------------------------------------------------------------
+# Apache Avro
+
+function(resolve_avro_dependency)
+ prepare_fetchcontent()
+
+ set(AVRO_USE_BOOST
+ OFF
+ CACHE BOOL "" FORCE)
+
+ set(AVRO_BUILD_EXECUTABLES
+ OFF
+ CACHE BOOL "" FORCE)
+
+ set(AVRO_BUILD_TESTS
+ OFF
+ CACHE BOOL "" FORCE)
+
+ fetchcontent_declare(Avro
+ ${FC_DECLARE_COMMON_OPTIONS}
+ GIT_REPOSITORY https://github.com/apache/avro.git
+ GIT_TAG 1144cb7322bab4cd1c8bf330a9c504a0d4252b56
+ SOURCE_SUBDIR
+ lang/c++
+ FIND_PACKAGE_ARGS
+ NAMES
+ Avro
+ CONFIG)
Review Comment:
I cloned your commits and tried to make it work on my end. However, it seems
that the Avro C++ library does not export CMake config file:
https://issues.apache.org/jira/browse/AVRO-3088. It means that we have to
maintain a `FindAvro.cmake` file to manually find the header file and libraries
from the installed location. I will try to fix this on the Avro side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
